ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
6 stars 3 forks source link

[IN REVIEW] Add vanishing strain wrapper (for plane strain) #317

Closed henrij22 closed 2 months ago

henrij22 commented 3 months ago

This adds a Material Wrapper for vanishing strain, mostly used by plane strain, this should work similar to planeStress from the VanishingStress implementation, but without using a nonlinear solver and directly setting the fixed indices of the strains to zero Original implementation by @tarun-mitruka

Ive tested the plane Strain case against my own implementation, but I havn't wrote a formal test with some actual values. It passes the testmaterials test and an additional one where i compare plane strain and plane stress for $\nu = 0$ where the two 2d models should match.

TODO

MAYBE TODO

OTHER PR

DONE

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.76%. Comparing base (d05187e) to head (662e3ee).

Files with missing lines Patch % Lines
...iteelements/mechanics/materials/vanishingstress.hh 71.42% 2 Missing :warning:
...us/finiteelements/mechanics/materials/interface.hh 0.00% 1 Missing :warning:
...teelements/mechanics/materials/linearelasticity.hh 50.00% 1 Missing :warning:
...rus/finiteelements/mechanics/materials/neohooke.hh 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #317 +/- ## ========================================== + Coverage 80.96% 86.76% +5.79% ========================================== Files 68 69 +1 Lines 2291 2222 -69 ========================================== + Hits 1855 1928 +73 + Misses 436 294 -142 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/317/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `86.76% <90.74%> (+5.79%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

henrij22 commented 3 months ago

@rath3t There are some open points to discuss, but for a first review this is ready from my side.

henrij22 commented 2 months ago

@rath3t Then this is mergable?