Closed zangetsudo closed 6 years ago
Hi!
code in else imply you are going to do somethings in checkMifareClassicSupport but seems pointless. they are all return value which is less then zero.
But the big else branch is why I have to do this in the first place. It is not only about knowing if both, tag and device, support Mifare Classic. The other case is just as important. Android is not able to tell you wether it is the device or the tag that does NOT support Mifare Classic. I need this stuff to display a proper error message ("not a Mifare Classic tag" vs. "Your phone does not support Mifare Classic").
I'm not sure if your observation is general thing of if you actually have a tag that was identified the wrong way. If you actually have such a tag it would be great if you could test the new identify process that I implemented in this test version.
Any news on this?
Is there anyone else with a bunch of different NFC cards that is willing to test whether the new Mifare Classic check works as expected? You can use this testing version. The expected behavior would be, that MCT should tell you if a tag is Mifare Classic or not.
Hmm... Still no updates. I hope the changes will work for most people because I will merge them now.
The changes have been released with version 2.2.0 (a44921d5156996d0a6ed1d7e8469fe7a5daefb67). Let's hope that it will work for everybody.
It works to me. Tested with a couple of tags and these are the results
I don't have any ultralight at hand, but I'll try and check them as soon as I find where I left those :-)
Thanks for testing! Unfortunately I don't have any Mifare Plus in SL1 to check what is causing the issue you mentioned. :-/
Don't worry, it looks more like an OS issue... If you need any further testing contact me :-)
Checked yesterday against two Mifare Ultralight cards: they are both detected correctly ;-)
That's great! Thanks.
checkMifareClassicSupport method has two issues(as far as i can tell)
the logic in checkMifareClassicSupport doesnot seem right. please double check the code around nfca.getAtqa.
full value of SAK