ikawaha / kagome

Self-contained Japanese Morphological Analyzer written in pure Go
MIT License
804 stars 53 forks source link

Release candidate #321

Closed ikawaha closed 3 months ago

KEINOS commented 3 months ago

It seems that you need to merge this PR to v2 branch first before running the "release" action.

Looking at the below failed action log of "release";

https://github.com/ikawaha/kagome/actions/runs/8630665114/job/23657420113#step:8:23

Both DockerHub and GHC login are success. And reading the mapped GITHUB_TOKEN as well. So far so good.

But when getting and validating git state step, it is comparing the "develop" branch. Which doesn't have the version tag info. Such as v2.9.5. "v2" branch has, tho.

Due to matching the version of the binary name/image tag and the source, goreleaser requires to match the commit ID of tagged version, and the current source commit ID.

Thus, you need to:

  1. Merge this PR to v2
  2. Tag a new version v2.9.6-beta or v2.9.6 and push the tag
  3. Create a new release

We are so close to close #319! 🤞