ike3 / mangosbot

This is a modification of MaNGOS (Zero, One, R2, Trinity) server which brings a number of bots online and available for any player. Also allows you to use your account/guild characters as bots.
http://ike3.github.io/mangosbot-docs/
GNU General Public License v2.0
183 stars 78 forks source link

Feyzee LFG Fix #43

Closed ghost closed 8 years ago

ghost commented 9 years ago

Merge Feyzee's LFG Fix into trinity-wotlk-ai ; closes issue https://github.com/ike3/mangosbot/issues/19. Enable TrinityCore Auction House Bot instead of ike3 AHbot.

Removed Rochet2 Transmog patch. Reduced Feyzee's /src/ to 19 files instead of 2157, thereby avoid reverting core scripts to their 2014 version. (Feyzee never changed any boss scripts, instances or zones.)

Kittnz commented 9 years ago

I haven't been able to compile with last pull from tc tho.

ghost commented 9 years ago

Hm, I wonder what may have changed. It was time-consuming enough to single out these 19 files and make the commit, but I also want to test and see if it is possible to merge again and then compile. Edit; fun fact or trivia: https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Northrend/zone_wintergrasp.cpp still uses the header /* Copyright (C) 2008 - 2009 Trinity http://www.trinitycore.org/ (https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Northrend/zone_wintergrasp.cpp#L1)

Kittnz commented 9 years ago

It's something to do with "format.h".

https://github.com/TrinityCore/TrinityCore/commit/66ce97c87e347ab9426ffbd60b6fe5aa90a96b9b maybe i can check it out again later..

ghost commented 9 years ago

OK, I will update the files with wrong header change, then test compiling it as it is, then try merging again with current TC and test compiling to see if it fails on format.h - I have seen that error before.

ghost commented 9 years ago

With this PR included, compiling in VS2013 works just as intended (79 warnings, though). Win64 build:

22>------ Build started: Project: INSTALL, Configuration: Release x64 ------
22>  -- Install configuration: "Release"
22>  -- Installing: C:/Program Files/AI Playerbot/authserver.exe
22>  -- Installing: C:/Program Files/AI Playerbot/authserver.conf.dist
22>  -- Installing: C:/Program Files/AI Playerbot/worldserver.exe
22>  -- Installing: C:/Program Files/AI Playerbot/worldserver.conf.dist
22>  -- Installing: C:/Program Files/AI Playerbot/plugins.lib
22>  -- Installing: C:/Program Files/AI Playerbot/aiplayerbot.conf.dist.in
22>  -- Installing: C:/Program Files/AI Playerbot/ahbot.conf.dist.in
22>  -- Installing: C:/Program Files/AI Playerbot/mapextractor.exe
22>  -- Installing: C:/Program Files/AI Playerbot/vmap4assembler.exe
22>  -- Installing: C:/Program Files/AI Playerbot/vmap4extractor.exe
22>  -- Installing: C:/Program Files/AI Playerbot/mmaps_generator.exe
========== Build: 22 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

Win32 build ; same as above, but with 81 warnings :

22>------ Build started: Project: INSTALL, Configuration: Release Win32 ------
22>  -- Install configuration: "Release"
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/authserver.exe
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/authserver.conf.dist
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/worldserver.exe
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/worldserver.conf.dist
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/plugins.lib
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/aiplayerbot.conf.dist.in
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/ahbot.conf.dist.in
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/mapextractor.exe
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/vmap4assembler.exe
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/vmap4extractor.exe
22>  -- Installing: C:/Program Files (x86)/AI Playerbot/mmaps_generator.exe
========== Build: 22 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

Not sure what accounts for the difference in number of warnings, but it compiles OK.

@Kittnz : I haven't tested any merging with newer source yet, but will do that at a later time.

ghost commented 8 years ago

Closing this PR because of too many commits that are already in the original source. Will make another attempt at creating a PR at a later date if the Feyzee LFG fix is needed.