ikeboy / pluralsight-scraper

Pluralsight video downloader
https://www.knyz.org/blog/post/pluralsight-scraper-released/
GNU General Public License v2.0
139 stars 50 forks source link

Updates #5

Closed Darkle closed 6 years ago

Darkle commented 6 years ago
ryanjerskine commented 6 years ago

I think this repo might be dead. If you are interested in a similar scraper, feel free to do a similar pull request on https://github.com/ryanjerskine/pluralsight-scraper . If not, I might steal using the .env file if that's ok.

vezaynk commented 6 years ago

It's not dead until it stops working at which point I will put up some text saying "does not work, try x or y instead".

It has bugs, I do not plan on improving it anytime soon but I will gladly handle community contributions.

vezaynk commented 6 years ago

It all looks good. Could you explain the regex change? It should have already been stripping all undesirable characters unless if I forgot how it worked.

Anyways, I love the env stuff!

Darkle commented 6 years ago

It all looks good. Could you explain the regex change? It should have already been stripping all undesirable characters unless if I forgot how it worked.

Yeah sure, I was downloading a tutorial that had a video with a question mark in its title, which seems to be a disallowed character for file names on windows.

The regex I added says to replace anything that isn't an a-to-z character. It might be a bit of an aggressive regex so you could pair it down to maybe just replace characters that aren't allowed in file names.