ikegami
commented
13 years ago On Wed, Mar 30, 2011 at 3:33 PM, Corion < reply@reply.github.com>wrote:
This branch contains "all" my changes, that is, it adds the tests and it makes :content_cb work.
Theoretically, "pull"ing this change into your main repo should just work without any conflict.
github provided instructions on how to pull into a branch. awesome!
Reply to this email directly or view it on GitHub: https://github.com/ikegami/perl-LWP-Protocol-AnyEvent-http/pull/1
Pushed.
- <<return \$_[0]>> didn't work for me in production code in the Coro version. I'll have to test this.
- Is there a reason to clear all the captures? If there's a memory leak, then it'll still leak on exception.
- Both tests just outputs endless series of "# Waiting for reply" for me. I haven't looked into this yet.
- The status may change (e.g. due to timeout), so the response's headers needs to be updated on error. I'll fix this after the tests work.
This branch contains "all" my changes, that is, it adds the tests and it makes :content_cb work.
Theoretically, "pull"ing this change into your main repo should just work without any conflict.