search

ikegami / perl-LWP-Protocol-AnyEvent-http

Event loop friendly HTTP and HTTPS backend for Perl's LWP
http://search.cpan.org/dist/LWP-Protocol-AnyEvent-http/
Creative Commons Zero v1.0 Universal
9 stars 6 forks source link

Fix the non-detection of bogus hostnames #3

Closed Corion closed 13 years ago

Corion commented 13 years ago

This adds a test and the fix for invalid URLs. These led to stalling instead of detectable errors.

ikegami commented 13 years ago

push @data in the completion handle pushes the arguments on backwards. I don't know how that even works!? Anyway, it's fixed.

I don't know why, but your pushes always include commits I wrote and committed to the master already, leading to duplicate commits in the master. Perhaps you should be using "git rebase" instead of whatever you do to update your branch?

Anyway, I merged your changes, and fixed that data queue in subsequent commits.

To address the host name issues, I'm thinking of prefacing the tests with a baseline, a test that doesn't use AnyEvent that demonstrates the problem the module is suppose to fix. If that test doesn't perform as expected, explain the situation in a message and possible skip the rest of the test file.