search

ikemen-engine / Ikemen-GO

An open-source fighting game engine that supports MUGEN resources.
https://ikemen-engine.github.io
Other
741 stars 126 forks source link

Explod shadows unimplemented #1385

Open potsmugen opened 1 year ago

potsmugen commented 1 year ago

Describe the bug

Title should be self-explanatory. The shadow parameter in Explods does not work in Ikemen GO.

shadow = shadow (int) If shadow is not 0, a shadow will be drawn for the explod, else no shadow will be drawn. Defaults to 0.

Note: It's not specified in Mugen's documentation, but this parameter likewise enables reflections.

To Reproduce

  1. Add shadow = 1 to KFM's explods
  2. Select a stage with shadows or reflections

Expected behavior

Same as Mugen 1.1.

Screenshots / Video

Mugen 1.1 mugen011

Ikemen GO ikemen154

Engine Version (or source code date)

27/08/2023

Operating system

Windows

Extra context or search terms

No response

Ksylatarsh commented 1 year ago

Isn't it supposed to be shadow = -1?

potsmugen commented 1 year ago

Going by Elecbyte's documentation I suppose it's a boolean. So anything that's not 0 will have the same result.

potsmugen commented 7 months ago

Looks like Ksylatarsh was right afterall. I just realized that this parameter works different between Mugen 1.0 and 1.1, and I only consulted 1.1's documentation.

The way it's currently implemented in Ikemen is the Mugen 1.0 RGB way, which is superior. I think this parameter needs a mugenversioncheck for 1.1 chars, where the parameter is a boolean.

And with ikemenversion it should use 1.0 behavior because it's more flexible.