ikemen-engine / Ikemen-GO

An open-source fighting game engine that supports MUGEN resources.
https://ikemen-engine.github.io
Other
699 stars 124 forks source link

strange opening moves #1601

Open shadowpage opened 7 months ago

shadowpage commented 7 months ago

Describe the bug

The opening move of some characters are very strange.

To Reproduce

  1. Download character from https://files.gamebanana.com/mods/balrog_sf2.zip
  2. Extract it to \chars folder, then edit select.def, add "Balrog SF2" in [Characters] section.
  3. Start game, choose "Balrog SF2" to play.

Expected behavior

Mugen won't show the strange opening moves.

Screenshots / Video

https://github.com/ikemen-engine/Ikemen-GO/assets/6863595/4442666d-9f38-4393-9c33-b1e34fa8c93b

Engine Version (or source code date)

v0.99.0

Operating system

None

Extra context or search terms

No response

Finally1994 commented 7 months ago

ikemen010 I had an idea before watching the video, but when I opened the cns file, I noticed that this "Balrog SF2" still has the KFM wooden explod description in the intro. The anim191 used by this explod is an anim that does not have any frames registered. In such cases, mugen is displayed as a transparent anim, but Ikemen seems to display the same anim as the main body. I also tested it in my own environment.I copied the explod description on the KFM wooden board to the character I had, registered an empty anim, and reproduced it.

potsmugen commented 7 months ago

Ideally an animation that is incorrectly defined like that should just make the engine crash when loading the char. But we can't do that because of backward compatibility. Would flag this as a minor issue I guess.