search

ikemen-engine / Ikemen-GO

An open-source fighting game engine that supports MUGEN resources.
https://ikemen-engine.github.io
Other
687 stars 121 forks source link

Custom common fx prefix issues #1620

Open ViolinKen opened 6 months ago

ViolinKen commented 6 months ago

Describe the bug

I seem to get an error with custom common fx prefixes. The prefix SF specifically doesn't work. My theory is that it's likely due to "S" for fightfx sounds and "F" for Fightfx animations already being defined.

I switched the prefix to "test" and it worked just fine.

To Reproduce

  1. Download universal brutality - https://github.com/RealFoobs/universal-brutality/
  2. In GIBS.def, change prefix from GIB to SF
  3. Run Ikemen, load character, see error.

Expected behavior

As a result of this issue, I'm unable to name my prefix as SF for street fighter.

I'm also unsure if SF6 as a prefix would work due to the 6 integer, which could be misread as part of the animation def.

Screenshots / Video

image

Engine Version (or source code date)

Nightly

Operating system

Windows

Extra context or search terms

common fx

potsmugen commented 6 months ago

It looks like the first letter of a prefix can't be S or F. They can be used in the middle or end of the string though.