ikemen-engine / Ikemen-GO

An open-source fighting game engine that supports MUGEN resources.
https://ikemen-engine.github.io
Other
736 stars 126 forks source link

Characters with trailing comma causes to crash the game #1943

Open TRRESTGHGYTCFTGBCXSZD opened 3 months ago

TRRESTGHGYTCFTGBCXSZD commented 3 months ago

Describe the bug

This character has trailing comma, and the parser treats empty string as invalid attribute, so this causes the game to crash. An Attribute with Trailing Comma:

[State 0, HitOverride]
type = HitOverride
trigger1 = Pos Y != 0
attr = SCA,NA,SA,HA,NP,SP,HP,
stateno = 5030
time = 1
forceair = 1
ignorehitpause = 1

To Reproduce

  1. Download character from Click Here! (any characters with trailing comma works)
  2. Try to Start the match
  3. See error

Expected behavior

It should ignore trailing comma and run normally.

Screenshots / Video

No response

Engine Version (or source code date)

v0.99.0

Operating system

Windows

Extra context or search terms

No response

potsmugen commented 3 months ago

That is bad syntax on the author's part, so it's probably not a priority to fix. If there's anything to fix at all.