ikemen-engine / Ikemen-GO

An open-source fighting game engine that supports MUGEN resources.
https://ikemen-engine.github.io
Other
717 stars 125 forks source link

FightFX Scale is not implemented. #20

Closed Windblade-GR01 closed 3 years ago

Windblade-GR01 commented 5 years ago

Iniside the figth.def is a function that is FightFX Scale it looks like this:

[FightFx]
scale = 4

It's one of the Mugen 1.0 lifebar new features that is not implemented.

K4thos commented 3 years ago

https://github.com/K4thos/Ikemen_GO/commit/944739524f7cdedbb1659008fc1cff75d19660e3 Implemented, although I'm still not sure if FightFx scale implementation is accurate. Based on my tests it works with:

But it didn't work correctly for add004 lifebar that uses 320x180 localcoord, fightfx scale = 1. That was the reason why this feature was not implemented for so long.

As a workaround I've added scale adjustment when Y localcoord < 240 by dividing these values and it seems to do the job, although I'm not sure if this is not just coincidence. We will see if there will be any reports regarding this functionality.