search

ikeshwani / HorizontalConvection

2 stars 1 forks source link

Refactor simulation to cover both Ny==1 and Ny>1 cases #17

Closed hdrake closed 4 months ago

hdrake commented 4 months ago

Generally looks good, but I recommend refactoring the code to make it easier to switch between Ny==1 and Ny>1

Originally posted by @hdrake in https://github.com/ikeshwani/HorizontalConvection/pull/15#pullrequestreview-2192642769

hdrake commented 4 months ago

@ikeshwani, https://github.com/ikeshwani/HorizontalConvection/commit/2cc11577abed0aab09debfbe2219ff097918fdbb looks good to me. Feel free to merge into main and close this issue.

hdrake commented 4 months ago

@ikeshwani, I think you've fix some bugs you ran into locally but they are not pushed here yet. Can you create a PR, merge it, and then close this comment?