search

ikeshwani / HorizontalConvection

2 stars 1 forks source link

Do we still need `with_halos`? #24

Open hdrake opened 3 months ago

hdrake commented 3 months ago

Do we still need the halos in the diagnostics? We originally used those to correctly calculate gradients cross the boundary, but now I think we always do this online.

If we want to keep them, we should save the size of the halos in the global_attributes so they can be accessed in analysis rather than hardcoded the limits [4::-4] whenever accessing the output.

ikeshwani commented 3 months ago

so with_halos is printing the data with halos? I think you're right, don't think we need them. I'm always removing them manually anyway.

hdrake commented 3 months ago

Throwback to the Issue we found when we were originally using the halos to compute $\chi$ offline.

https://github.com/CliMA/Oceananigans.jl/issues/3224