search

ikey4u / wikit

Wikit - A universal lookup tool
MIT License
204 stars 16 forks source link

include Cargo.lock into the repository #11

Closed proletarius101 closed 1 year ago

proletarius101 commented 1 year ago

This lockfile is recommend to be checked into git as it's an end-user application.

If you’re building an end product, which are executable like command-line tool or an application, or a system library with crate-type of staticlib or cdylib, check Cargo.lock into git

ikey4u commented 1 year ago

Hi, thank you for your contribution. Please remove the Cargo.lock file and PR only with the .gitignore file (I will submit Cargo.lock later) @proletarius101

proletarius101 commented 1 year ago

Hi, thank you for your contribution. Please remove the Cargo.lock file and PR only with the .gitignore file (I will submit Cargo.lock later) @proletarius101

Done. Yes, that's safer.

ikey4u commented 1 year ago

@proletarius101 Format of the commit should follow this convention https://www.conventionalcommits.org/en/v1.0.0/. But as this is the first PR for wikit project, it will be ok. Thank you!