search

ikey4u / wikit

Wikit - A universal lookup tool
MIT License
204 stars 16 forks source link

Does not run on Wayland natively #8

Closed Congee closed 1 year ago

Congee commented 2 years ago

Because global shortcuts is only supported on X11. See: https://github.com/tauri-apps/tao/issues/248

Is there a way to disable global shortcuts as a workaround?

ikey4u commented 2 years ago

Hi, I have disabled global-shortcut-all feature of tauri, can you have a try of branch fix-wayland?

Congee commented 2 years ago

Thank you for that fix attempt. I still see the same error.

Congee commented 2 years ago

Do you have a contributing guide for developers to participate in? Maybe I can submit a patch easily if there's a guide that can walk me through the code :grin:

ikey4u commented 2 years ago

Sorry, there is no contribution guide yet. The project consists of three parts, the core library (wikit/core),the cli tool (wikit/cli),the desktop gui (wikit/desktop). You can start with the desktop gui code (required basic knownledge of svelte and tauri framework). No constrict on contributing, feel free to PR and I will review the PR before merging. Thank you.

ikey4u commented 2 years ago

I have tried v0.0.1-beta.2 on ubuntu 20.04 with wayland window environment installed, it works without any problem. As a result, it maybe not a problem of wayland.

Congee commented 2 years ago

I guess you have Xwayland running so tauri actually still uses X. Anyway, it's an upstream problem. If it cannot be simply worked around by disable the global shortcuts feature, I can dive into the code for some luck ;)

ikey4u commented 2 years ago

Can you give your linux environment? Maybe i can try to reproduce the issue locally.

Congee commented 2 years ago

I really appreciate your willing to help but I've been using NixOS. Though it's reproducible but not easy to get started with.

I would suggest you kill Xwayland or manually set the environment variable for X to be empty like DISPLAY='' to run wikit desktop

$ DISPLAY='' wikit
ikey4u commented 1 year ago

I have no wayland environment to test wikit dictionary, as a result, I will close this issue. Anyone who have the same issue can reopen or @ me directly.