Improve error handling - Githubissues

ikifar2012 / remote-backup-addon

Automatically create and backup HA snapshots using SCP

30 stars 4 forks source link

Improve error handling #59

Closed patman15 closed 2 years ago

patman15 commented 2 years ago

This is again a bigger change in the code adding better error handling, persistent notification in case of a failure, and an event is fired at the end of each run to allow custom automations. Please see the individual commits for details. Note: rclone has not been tested!

ikifar2012 commented 2 years ago

looks awesome although I would like to keep documentation as part of the documentation website, if you could move that over here that would be great

patman15 commented 2 years ago

looks awesome although I would like to keep documentation as part of the documentation website

Sure, I can do so. Should I just create a separate PR against the documentation or how is this handled? I wonder how documentation and code are kept synchronous as there are significant changes that are not backwards compatible. Do you want to have it

exclusively there or
on both or
could we at least keep the security hints in the local version?

ikifar2012 commented 2 years ago

The reason I originally decided to keep documentation exclusively on a separate webpage was for ease of updating without having to change publish a new addon release as I am using the repository updater to manage files in the main ha-addons repo. I think for now we should just keep everything on the site, The website is entirely markdown based and a preview link will be generated on your PR so you can view your changes

patman15 commented 2 years ago

I created another PR and one for the documentation as requested for all of the open PRs.