use of obsolete functions

ikirill / irony-eldoc

irony-mode support for eldoc-mode

30 stars 9 forks source link

use of obsolete functions #5

Closed soonhokong closed 7 years ago

soonhokong commented 9 years ago

Hi,

I'm using GNU Emacs 25.0.50.1 (on Ubuntu-12.04) and found some problems in irony-eldoc.el file. It gives me the following errors:

eldoc error: (void-function async-flag)
eldoc error: (void-function remove-if-not)

I think a possible fix is

replace remove-if-not with cl-remove-if-not
replace lexical-let with let

at least, this fixes it on my machine.

ghost commented 9 years ago

Confirming. This fixes the eldoc errors for me as well.

mambolevis commented 8 years ago

Compiling no file at Fri May 6 22:00:02 2016 Warning (bytecomp): ‘(callback-thing (cdr thing))’ is a malformed function Warning (bytecomp): reference to free variable ‘callback-thing’ Warning (bytecomp): reference to free variable ‘async-flag’ Warning (bytecomp): assignment to free variable ‘matches-available’ Warning (bytecomp): assignment to free variable ‘async-flag’ Warning (bytecomp): reference to free variable ‘matches-available’ Warning (bytecomp): the following functions are not known to be defined: remove-if-not, lexical-let, async-flag, matches-available

nickbroon commented 7 years ago

@ikirill Can you merge @josteink's fix for this?

ikirill commented 7 years ago

Merged in #9.