non-root fixes - Githubissues

ikke-t / podman-container-systemd

creates systemd files and creates containers using podman

118 stars 44 forks source link

Closed Mosibi closed 4 years ago

Mosibi commented 4 years ago

fix error message 'fatal: [host]: FAILED! => {"changed": false, "msg": "line is required with state=present"}' by using backrefs to recreate the original line
Added when statement for the subuid and subgid checks which do not run the check is the user or group is root
Fix bug, container_run_as_user was used in the when statement instead of container_run_as_group for /etc/subgid

ikke-t commented 4 years ago

Hi, thanks for spotting that out. Can you please advice me what is that backref black magic ( :smile: ) as I don't get what it's needed for?

ikke-t commented 4 years ago

ah, got it, it caused you ansible error without it. odd.

Mosibi commented 4 years ago

Thanks for merging. The backref option is the Ansible way of regular match references, for example using sed:

$ echo 'hello world'|sed -E 's/(.*) world/\1 ikke-t/g'
hello ikke-t

In this change I used it to get the complete line and put that as a value after line: