ikke-t / podman-container-systemd

creates systemd files and creates containers using podman
118 stars 44 forks source link

Fix the subuid & subgid user detection and addition. #18

Closed romainsc closed 3 years ago

romainsc commented 4 years ago

Hi,

The subgid and subuid check part was not working on my setup (a vanilla RHEL 8 server).

I found a different way to check line presence and after some tests it works.

Perhaps this way will improve further usage.

romainsc commented 4 years ago

Hi @ikke-t ,

I found this solution in multiple Stackoverflow pages, ie:

But your remark triggered additional research in order to have a solution that is fully officially documented, and I found that the find module would do the job in a cleaner way.

Do you prefer I request another pull with an implementation based on this?

Best Regards,

ikke-t commented 4 years ago

That was really good find (happy to include the pun)! Looks cleaner and made for the purpose. Please do, test and rebase dropping the earlier trials.

romainsc commented 4 years ago

Hi @ikke-t , job done.