search

ikke-t / podman-container-systemd

creates systemd files and creates containers using podman
118 stars 44 forks source link

Use only `container_image_list` and remove `container_image` variable. #23

Closed lberezy closed 3 years ago

lberezy commented 4 years ago

This PR consolidates on using only the variable container_image_list, rather than the existing split between container_image_list and container_image when working with pods and standalone containers, respectively.

Actions for pods/standalone is done by testing the length of the list instead. This prevents an issue resulting in unintended behaviour where both container_image_list and container_image are both set.

Removal of container_image is a breaking change.

Resolves #22

Note: I have not tested this code at all.

ikke-t commented 4 years ago

Hi, thanks, I like what you did. Just please check my comments about if you dropped some code in purpose, and if so, did you test them both as user and as root?

I didn't try this myself, I just quickly looked the code and it caught my eye.