search

ikke-t / podman-container-systemd

creates systemd files and creates containers using podman
118 stars 44 forks source link

plenty of linter warnings #71

Open ikke-t opened 1 year ago

ikke-t commented 1 year ago

run ansible-lint in this directory, and you get tons of warnings. They are mostly about good practises, and many of them has appeared long after the role was written. However it would be nice to clean it up. In case someone is willing to practice some ansible best practises, this is for you :)

edenhaus commented 1 year ago

The following issues still exists after #72 is merged:

var-naming: File defines variable 'systemd_TimeoutStartSec' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:15

var-naming: File defines variable 'systemd_RestartSec' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:16

var-naming: File defines variable 'systemd_After' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:23

var-naming: File defines variable 'systemd_Before' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:24

var-naming: File defines variable 'systemd_Conflicts' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:25

var-naming: File defines variable 'systemd_RequiredBy' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:26

var-naming: File defines variable 'systemd_Requires' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:27

var-naming: File defines variable 'systemd_WantedBy' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:28

var-naming: File defines variable 'systemd_Wants' that violates variable naming standards (warning)
.roles/ikke_t.podman_container_systemd/defaults/main.yml:29

role-name: Role name ikke_t.podman_container_systemd does not match ``^[a-z][a-z0-9_]*$`` pattern. (warning)
.roles/ikke_t.podman_container_systemd/meta/main.yml:1

risky-file-permissions: File permissions unset or incorrect. (warning)
.roles/ikke_t.podman_container_systemd/tasks/main.yml:25 Task/Handler: Ensure systemd files directory exists if user not root

Changing the variable names is a breaking change and not sure if this is wanted