search

ikke-t / podman-container-systemd

creates systemd files and creates containers using podman
118 stars 44 forks source link

Use systemd task instead handler #73

Closed edenhaus closed 1 year ago

edenhaus commented 1 year ago

Requires #72 to be merged first!

I moved the restart service handler into the main as task because:

I know you have said in https://github.com/ikke-t/podman-container-systemd/issues/38#issuecomment-881941710 that anyone must verify that the service is running correctly afterwards but I think so we can ensure that the service was started also on mutliple runs

ikke-t commented 1 year ago

Hmm, did I merge in wrong order?

edenhaus commented 1 year ago

@ikke-t No but somehow git had a problem. I fixed the conflicts

ikke-t commented 1 year ago

Thanks. I wonder btw if the check for if image pull task had a change works nowadays? Long ago podman didn't return any info if the image really changed on disk. As it is used in when clause, there is chance it always triggers.

ikke-t commented 1 year ago

Github still says can't rebase due conflicts.

edenhaus commented 1 year ago

@ikke-t I have rebased it on the current master. You should be able to merge it now :)