ikke-t / podman-container-systemd

creates systemd files and creates containers using podman
118 stars 44 forks source link

add option "-t" to lighttpd container fixing Permission denied error in latest lighttpd container #9

Closed thinkingstone closed 4 years ago

thinkingstone commented 4 years ago

add option "-t" to lighttpd container to use pseudo tty in order to fix the error "(server.c.748) opening errorlog '/dev/pts/0' failed: Permission denied"

see also: https://github.com/spujadas/lighttpd-docker/issues/8

ikke-t commented 4 years ago

Thanks for your suggestion and finding. However I won't take in the '%T' -> '%t' change. It's just reverting what I changed some while back, see the recent commits. That would again break newer versions of systemd.

However, as you and probably others need it, please do some kind conditional check in there, and fill the template in with parameters which work on given version. In my systems those %t lines return empty string.

Unfortunately I don't know where it works and where it doesn't. It would be great if you could find out what would be proper test for it. Perhaps defautl '%T', and if older release, then '%t' . Note that it must work with non-root containers too.

cfelder commented 4 years ago

Hi I just added a conditional check for EL7 in #14 regarding using %t instead of %T which works for CentOS 7

Best Christian

ikke-t commented 4 years ago

I believe this is now fixed. We'll modify this part again once this is in the distributions: https://github.com/containers/libpod/issues/5572