iknowjason / PurpleCloud

A little tool to play with Azure Identity - Azure Active Directory lab creation tool
https://www.purplecloud.network
MIT License
498 stars 86 forks source link

Jinja2 instead of template_file. #28

Open mosesrenegade opened 1 year ago

mosesrenegade commented 1 year ago

While working on a different project, I came across a great idea for building Terraform Templates. This came from the Amazon Account Factory Terraform modules, which use jinja-cli to convert Jinja templates into Terraform files. I decided to refactor your phishing_app template. Please note the following:

dorp007 commented 1 year ago

Hello,

Please make the necessary changes to the file "requirements.txt" and submit that also as a pull request before contributing to this branch of [PurpleCloud]. For code review. Please note that this is the master branch and must be revised by other open-source software users before merging.

iknowjason commented 1 year ago

Hello,

Please make the necessary changes to the file "requirements.txt" and submit that also as a pull request before contributing to this branch of [PurpleCloud]. For code review. Please note that this is the master branch and must be revised by other open-source software users before merging.

This is a great idea for enhancement. But we need to make this change across all 8 of the generators, coordinate the changes, and update the documentation. Waiting to see if someone can make the changes or I'll prioritize this myself at some point in the future.