search

iknowjason / PurpleCloud

A little tool to play with Azure Identity - Azure Active Directory lab creation tool
https://www.purplecloud.network
MIT License
493 stars 85 forks source link

Issue with deplying helk #8

Closed mateusz-sobczak closed 2 years ago

mateusz-sobczak commented 2 years ago

The azure.py file uses wrong variable in "os_disk" method (line 1621), it should be: name = "${local.virtual_machine_name_helk}-disk1"

current value: name = "${local.virtual_machine_name}-disk1"

(Or "name" parameter should be removed?? like for endpoint & DC)

iknowjason commented 2 years ago

@mateusz-sobczak

Thanks for the heads up. I'm taking a look at this and will verify ASAP.

iknowjason commented 2 years ago

Hello @mateusz-sobczak

I've confirmed that you are correct. Very nice catch. Thank you. This issue has been resolved in latest commit.