Search feature - Githubissues

ikoamu / publish-org-roam-ui

Generates a static site for org-roam-ui from org-roam files managed on GitHub. And it is easy to publish to GitHub Pages.

https://ikoamu.github.io/publish-org-roam-ui/

GNU General Public License v3.0

45 stars 4 forks source link

Search feature #4

Closed ikoamu closed 7 months ago

ikoamu commented 8 months ago

search for nodes based on their titles or contents

Thysrael commented 8 months ago

Wow，that so cool!

ikoamu commented 8 months ago

I'd like to implement this at https://www.npmjs.com/package/flexsearch or https://www.algolia.com/

ikoamu commented 7 months ago

https://github.com/ikoamu/org-roam-ui/pull/2

ikoamu commented 7 months ago

Thysrael commented 7 months ago

Congrats on finishing the feature, I tried it out and it works great, so cool !!! Also I would like to ask about being able to have the focus fixed on the results of a search: when I search for a node, it works as if I clicked on that node. I noticed that you added this feature yourself and it's not an upstream feature. That's why I brought the issue to your attention. Just ignore me if something doesn't fit. Apologies for the intrusion.

ikoamu commented 7 months ago

@Thysrael Thank you always for your feedback! I truly appreciate it.

When you click on a card displayed as search results, the search modal closes, and it's implemented to display the node you clicked on. If there are any unnatural points or areas that could be improved, please let me know! Thank you.

Thysrael commented 7 months ago

Is there any way to move the search results node to the center of the screen or make him blink a bit. This would have the advantage of quickly locating the search node in the Org-Roam-UI, making it easy to further view other nodes that are linked to it.

ikoamu commented 7 months ago

Very good idea! I will respond as a separate issue. Thanks!