search

ikod / dlang-requests

dlang http client library inspired by python-requests
Boost Software License 1.0
154 stars 32 forks source link

Support openssl 1.3 #158

Closed skoppe closed 1 year ago

skoppe commented 1 year ago

On latest ArchLinux it didn't run anymore...

ikod commented 1 year ago

Thanks!

WebFreak001 commented 1 year ago

I think this added support for openssl 3.1, no?

skoppe commented 1 year ago

I think this added support for openssl 3.1, no?

The version I got was 1.3 though... That or this library mixed up the major/minor in here https://github.com/ikod/dlang-requests/blob/8ecd4bcd95c16c5ecdbe62a701416487702a7dfa/source/requests/ssl_adapter.d#L258

ikod commented 1 year ago

Sorry, I didn't tested this PR. Will try now.

ikod commented 1 year ago

Can you please check latest commit?

WebFreak001 commented 1 year ago

at least the change added in this PR is important for things to start working on Ubuntu 22.04 with libssl-dev installed, where otherwise it would break without this PR applied (the 1,3 version)

ikod commented 1 year ago

I pushed fixes, available tests passed. Please check

WebFreak001 commented 1 year ago

Micah on discord has been testing this for me and confirms it's still fixed with master right now, at least in their test case with attempting to start serve-d.

ikod commented 1 year ago

Thanks! Will publish release.