search

ikostrikov / pytorch-ddpg-naf

Implementation of algorithms for continuous control (DDPG and NAF).
MIT License
307 stars 72 forks source link

AttributeError for gradient clipping #1

Open andrewliao11 opened 7 years ago

andrewliao11 commented 7 years ago

hi ikostrikov, I got this error when running your code

Traceback (most recent call last):
  File "main.py", line 89, in <module>
    agent.update_parameters(batch)
  File "/home/andrewliao11/Work/pytorch-naf/naf.py", line 121, in update_parameters
    param.grad.data.clamp(-1, 1)
AttributeError: 'NoneType' object has no attribute 'data'

the original code is:

for param in self.model.parameters():
            param.grad.data.clamp(-1, 1)

maybe we should modify in into:

torch.nn.utils.clip_grad_norm(self.model.parameters(), 1)

I'm just a newbie to pytorch, not sure if it's right, thx!