iksaif / euscan

Ebuild Upstream Scanner
http://euscan.iksaif.net/
GNU General Public License v2.0
15 stars 14 forks source link

Add gnome handler #19

Closed EvaSDK closed 11 years ago

EvaSDK commented 11 years ago

Hi,

I found annoying to get so many weird results with generic handler so I took some time to exploit some files I recently discovered on gnome mirrors that helps greatly.

This is not exactly a pull request but rather a review request as I didn't exactly go through all the code to figure out the best way to get things done.

Doing this I found it a bit difficult to easily figure out what a handler should implement to support what kind of operations, so if you could document that in the future, that would be great.

iksaif commented 11 years ago

Looks ok to me, could you give me some packages names to test it ?

I think this handler is pretty gnome specific, so adding a new one was the right thing to do. And yes, documentation is lacking, that's bad, I'll try to get some time to fix that ... someday.

EvaSDK commented 11 years ago

You can test with nautilus, eog, eog-plugins, anjuta, etc. Some telepathy or gstreamer packages are also hosted on gnome mirrors.

Btw, wouldn't it be nice to have a specific exception for raise for cases found in this patch ?

If you have other locations that are brute-forced, could you list those so someone could work in implementing an appropriate handler ?

Finally, could you do a new release so gentoo-x86 has a code somewhat up to date ? :)

iksaif commented 11 years ago

Ok I'll test that this evening. Not sure what to do with exceptions yet.

For other locations that are brute forced, there is a plan to work on that !

And a new release .. yeah .. someday. app-portage/euscan-9999 should work, most of the time.

iksaif commented 11 years ago

Fox added some comments to the commit itself. Could you take a look ? Thanks.

EvaSDK commented 11 years ago

I think I fixed the issues you pointed out. I tested it with the full list of gnome packages in tree and it appears to work fine.

volpino commented 11 years ago

Great! I think @iksaif can merge it ;)

Thank you very much for your work! It's always great to have contributions from users

iksaif commented 11 years ago

Merged ! Thanks ! Will try to make it run today on euscan.iksaif.net