ikvmnet / ikvm

A Java Virtual Machine and Bytecode-to-IL Converter for .NET
Other
1.26k stars 118 forks source link

Workflow update #278

Closed bogatykh closed 1 year ago

bogatykh commented 1 year ago

Do we need 18.04 Ubuntu to build OpenJDK?

wasabii commented 1 year ago

We did when I originally put this together. The Lenny distro uses syscalls not available in later kernel versions, if I remember.

wasabii commented 1 year ago

You'll have to make sure the cache is expired, or it won't even try building, though. The IKVM.yml line for the name of the cache has a number at the end that you can incremement.

bogatykh commented 1 year ago

You'll have to make sure the cache is expired, or it won't even try building, though. The IKVM.yml line for the name of the cache has a number at the end that you can incremement.

OK I will check it out. Anyway we will have to figure out what to do with it due to depreciation At least we need to update github actions to latest versions, this looks safe to me.

wasabii commented 1 year ago

Yeah the versions are fine.

Gotta get the JDK upgraded. But it's such a slow process. The latest jdk8 builds fine.

bogatykh commented 1 year ago

@wasabii looks like intermittent failure of unit test Can_use_selector_to_answer_client_requests. Can we rerun workflow?

wasabii commented 1 year ago

@bogatykh You'll have to make that another commit to expire the OpenJDK build cache. Else we don't know whether it actually builds.

I have it cached because it takes a significant amount of time, and it's not like we ever change it.

bogatykh commented 1 year ago

@wasabii you may delete cached entry from web with write permissions (I don't have them). Take a look: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#deleting-cache-entries

I can make commit later to expire cache if above instructions won't work for you.

wasabii commented 1 year ago

You'll need to do it in your branch to generate a new cache entry for your branch (encapsulating your changes).

bogatykh commented 1 year ago

You'll need to do it in your branch to generate a new cache entry for your branch (encapsulating your changes).

Never done that. Can you please verify my last commit?

wasabii commented 1 year ago

All that said, the latest Ubuntu does appear to work. Good news.