search

ikvmnet / ikvm

A Java Virtual Machine and Bytecode-to-IL Converter for .NET
Other
1.28k stars 121 forks source link

`Assembly.Location` might return an empty string. #576

Closed Fabian-Schmidt closed 3 months ago

Fabian-Schmidt commented 3 months ago

Assembly.Location might return an empty string. Path.GetDirectoryName on Full Framework will then fail with The path is not of a legal form..

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

Fabian-Schmidt commented 3 months ago

Hi, I signed the CLA, but made first commit on my new Dev VM without correct setup git config and therefore wrong Name & EMail is associated with the commit. To fix it I would have to recreate the commits and recreate the PR. Do you want me todo this or is it acceptable in this state?

AliveDevil commented 3 months ago

You could also force push the changed commits.

wasabii commented 3 months ago

Hmm. I think I would like you to fix this. Just amend the history and force push. I think the risk is low, but it is tied to a legal thing and so might be important (to some person in the future).