search

ikyriak / IdempotentAPI

A .NET library that handles the HTTP write operations (POST and PATCH) that can affect only once for the given request data and idempotency-key by using an ASP.NET Core attribute (filter).
MIT License
280 stars 40 forks source link

Default name of idempotency header key #46

Open hartmark opened 1 year ago

hartmark commented 1 year ago

According to the rfc draft the proposed name would be Idempotency-Key so we should rename the default.

https://datatracker.ietf.org/doc/draft-ietf-httpapi-idempotency-key-header/

Comments?

ikyriak commented 1 year ago

Hello @hartmark As far as I can see, the Idempotency-Key header name is still an Internet-Draft. We can consider it as a work in progress. In addition, this will be a breaking change in the library.

However, I am unsure how the library is used and if the majority use the Idempotency-Key header name.

cc: @dimmy-timmy, @kvuong, @bernardiego, @MohamadTahir, @Rast1234, @lvzhuye, @RichardGreen-IS2, @apchenjun, @william-keller, @fjsosa

Rast1234 commented 1 year ago

i'm not an active user of your implementation, our impl uses custom header name because that standard is still a draft and we decided to ignore its existence until it's finished 😆 sticking to standards is good, but i'd contact someone responsible for that rfc to see if they are going to change header name. to avoid changing defaults again, you know