search

ikyriak / IdempotentAPI

A .NET library that handles the HTTP write operations (POST and PATCH) that can affect only once for the given request data and idempotency-key by using an ASP.NET Core attribute (filter).
MIT License
270 stars 39 forks source link

Specify the ExpireHour in Timestamp instead of int #59

Closed vIceBerg closed 9 months ago

vIceBerg commented 10 months ago

Hi!

In our usecase scenario, the int for the ExpireHours is not flexible enough.

We would like to be able to specify 10 minutes. Or 30. So forcing this parameter to be minimum 1 hour is not ideal.

Would it be possible to change the ExpireHours to ExpireDelay and from int to TimeSpan?

If I do a PR for it, would it be accepted?

ikyriak commented 10 months ago

Hello @vIceBerg Thank you for taking the time to report this. If you have time, please prepare a PR. Otherwise, I will implement it as soon as possible.

vIceBerg commented 10 months ago

Hi!

I'll try to do a PR today... Never done this, so maybe I'll need help with technical details

vIceBerg commented 10 months ago

Hi!

I try to push on a new branch and, of course, I get an unauthorized error. I need a little how-tos guide

vIceBerg commented 10 months ago

Ok I managed to do it! Pull Request is done!