search

ikyriak / IdempotentAPI

A .NET library that handles the HTTP write operations (POST and PATCH) that can affect only once for the given request data and idempotency-key by using an ASP.NET Core attribute (filter).
MIT License
270 stars 39 forks source link

Bugs/bug65 minimalapi #66

Closed hartmark closed 8 months ago

hartmark commented 8 months ago

I have added fix for when minimal API has endpoints using HttpContext or HttpRequest in its lambda definition.

Added some tests for it and hopefully I haven't messed up it too much.

I have tried my best to follow the general code conventions found in the repo.

Feel free to poke me for clarifications or modify files to fit the code conventions of the repo.

ikyriak commented 8 months ago

Closing this PR as we have created the PR https://github.com/ikyriak/IdempotentAPI/pull/67.

hartmark commented 8 months ago

Are you going to incorporate the DI simplify i committed aswell?

ikyriak commented 8 months ago

Yes, of course. I missed it. Thank you for letting me know. 🙏 If there is anything else that I missed, please let me know 😄