ikzelf / zbxdb

Zabbix database monitoring, the easy and extendable way
GNU General Public License v3.0
94 stars 45 forks source link

Reduce ambiguity around Application name grouping #21

Closed jedd closed 3 years ago

jedd commented 5 years ago

Is your feature request related to a problem? Please describe.

Zabbix has no hierarchy of Applications, so the current Application names in the template are spread across the alphabetic spectrum. There's also some ambiguity and potential clashes with some Application names, especially with some of our self-service dashboard users accessing these data from Graphana.

Application names in the v4_EN template include:

ACFS, ASM, ASMVG, backup, db, inst, inst.parm, inst.perf, locks, log, objects, performance, sql, tsmaxsize, tspctfree, tssize, tsused, ttsmaxsize, ttspctfree, ttssize, ttsused, undoTS, users, zbxdb

Describe the solution you'd like

Prefix each Application with a unique string - eg. db_ - so that the Applications are grouped together (as they're usually shown alphabetically), and remove ambiguity (eg. db_users is more obvious than just 'users')

Possibly consider scenarios where we have two database engines on the same host (it's not common, but I've seen MySQL and PostgreSQL on the same host) - which in the current, and even my proposed change, will break in weird ways. I have no idea how to elegantly handle that situation.

Describe alternatives you've considered

I can modify the template myself, but this will break on future updates to that file.

Also, the XML wrangling isn't something that's easy to automate.

ikzelf commented 5 years ago

Hi Jedd, dreaming up names is not my best skill ... so I am open for any improvement but prefixing them seems like a good idea. With the situation in which you have 2 different db engines on a single host .... how would that break in zabbix? (each db has it's own zabbix host_name (that you choose)) Also, in the inventory the db_type can be found.(db_engine would have been a better name ....)

If you have idea's for improvement, let's discuss them.

Also, you van view the templates that I uploaded as an example, not as something that is solid as concrete. As long as the generated item keys match those in the discovery rules, nothing breaks.