search

ilTofa / rposx

The official OS X client to the Radio Paradise web radio.
http://www.ilTofa.com/rphd/index.html
20 stars 8 forks source link

Hello, I just added the "continuous=YES" property to the slider. This maked adjusting the volume much nicer. Want to add airplay later on. #1

Closed cgommel closed 10 years ago

ilTofa commented 10 years ago

I merged the other request already. I'm OK with this request (also with monochrome icon ;) ) but instead of killing piwik integration it will better if you add on your side a piwikinfo.com with dummy values, say:

define PIWIK_URL @"http://example.com/"

define SITE_ID @"1"

define PIWIK_TOKEN @"1d2d67def9926adddd77a1c2e3cb4"

Integrating your patch will otherwise render the project not compilable for App Store distribution (as it is distributed)... can you put back 5dd6ba8? Probably f9d9186 can also be skipped because it is already integrated with your other commit. Otherwise I can revert the changes myself after integration. Make me know how do you want to do (and if you agree with my comment). ;)

Thank you again for your contribution!

cgommel commented 10 years ago

Hello,

you’re right. I don’t like tracking users with PIWIK or so but I dd not want to include this change in the pull request.

I recently added some rudimentary Notification Center support that needs to be optimized further.

But first of all I re-enabled piwik so that you can „use“ all my further changes.

I am considering to add a volume control to the status icon menu but before this needs to be converted to a custom NSView. Or am I wrong?

regards

Christoph Am 10.01.2014 um 16:08 schrieb ilTofa notifications@github.com:

I merged the other request already. I'm OK with this request (also with monochrome icon ;) ) but instead of killing piwik integration it will better if you add on your side a piwikinfo.com with dummy values, say:

define PIWIK_URL @"http://example.com/"

define SITE_ID @"1"

define PIWIK_TOKEN @"1d2d67def9926adddd77a1c2e3cb4"

Integrating your patch will otherwise render the project not compilable for App Store distribution (as it is distributed)... can you put back 5dd6ba8? Probably f9d9186 can also be skipped because it is already integrated with your other commit. Otherwise I can revert the changes myself after integration. Make me know how do you want to do (and if you agree with my comment). ;)

Thank you again for your contribution!

— Reply to this email directly or view it on GitHub.

ilTofa commented 10 years ago

I don't like tracking too (more than this, I actively hate it)... :) But I think that use of piwik on a personal instance (ie: not giving your user data to some big corp) on an open source program (ie: you can personally check what information are tracked, in this case only machine, os version and what features are used) can be "fair use". Also: this app is server-driven... most of the data are available also on the server end-point, I think this usage only clarifies things from the user point of view. So said: do you think I should add a "don't track" option to the preferences? It can be made easily. ;) Again thank you for the code, I'll merge it later this night, if you told me it's ready to be merged!

cgommel commented 10 years ago

Hello,

I don’t care if someone tracks the usage of a software as long as it can be disabled.

So an opt-out would be great.

The code for the notification center is OK so far and ready to be merged.

There are some things in my mind that need to be done:

Cheers!

Christoph

Am 13.01.2014 um 08:56 schrieb ilTofa notifications@github.com:

I don't like tracking too (more than this, I actively hate it)... :) But I think that use of piwik on a personal instance (ie: not giving your user data to some big corp) on an open source program (ie: you can personally check what information are tracked, in this case only machine, os version and what features are used) can be "fair use". Also: this app is server-driven... most of the data are available also on the server end-point, I think this usage only clarifies things from the user point of view. So said: do you think I should add a "don't track" option to the preferences? It can be made easily. ;) Again thank you for the code, I'll merge it later this night, if you told me it's ready to be merged!

— Reply to this email directly or view it on GitHub.

ilTofa commented 10 years ago

I just merged all and created some issues for your proposals (so we can merge/discuss point for point). Some comments are in the single issues.

Il giorno 14/gen/2014, alle ore 22:45, cgommel notifications@github.com ha scritto:

Hello,

I don’t care if someone tracks the usage of a software as long as it can be disabled.

So an opt-out would be great.

The code for the notification center is OK so far and ready to be merged.

There are some things in my mind that need to be done:

  • Airplay
  • better behavior around suspend / hibernate. Probably we should do this by using IORegisterForSystemPower
  • Inclusion of a volume slider into the status menu or better: building a custom view instead of the status menu (like Dropbox or CrashPlan do)

Cheers!

Christoph

Am 13.01.2014 um 08:56 schrieb ilTofa notifications@github.com:

I don't like tracking too (more than this, I actively hate it)... :) But I think that use of piwik on a personal instance (ie: not giving your user data to some big corp) on an open source program (ie: you can personally check what information are tracked, in this case only machine, os version and what features are used) can be "fair use". Also: this app is server-driven... most of the data are available also on the server end-point, I think this usage only clarifies things from the user point of view. So said: do you think I should add a "don't track" option to the preferences? It can be made easily. ;) Again thank you for the code, I'll merge it later this night, if you told me it's ready to be merged!

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

Giacomo Tufano http://www.ilTofa.com/

Ever tried. Ever failed. No matter. Try again. Fail again. Fail better. (S. Beckett)