search

ilabafrica / rhtpt

Kenya National HIV Serology Proficiency Testing System
0 stars 2 forks source link

Updating evaluated results #112

Closed annchemu closed 6 years ago

annchemu commented 6 years ago

@mapesa Kindly review

First create the table evaluated_results before saving any changes (check the seed folder for the create sql statement)

mapesa commented 6 years ago

@annchemu In conclusion, the edit feature looks functional so I'd say go ahead and merge.

One caveat, I didn't see any trail that captures who did what when. We need to be sure we don't lose data on editing.

I'd suggest the following approach:

  1. make the minor edit suggested above,
  2. pull the latest changes from the lar-53 branch and merge them into your branch
  3. push your branch
  4. create a pull request of your branch on github and merge into lar-53
  5. On the live server, just pull and run your db table creator. That way there wil be no conflicts to be resolved on the server.
mapesa commented 6 years ago

btw, the results page allows partners to view all results and submit the ones that are NOT CHECKED. They should be restricted to their counties. Combinations of the Region, Feedback and Submission status show disregard the users role eg, an SCMLC can see results of everyone in the county.

annchemu commented 6 years ago

@mapesa Thanks for the suggestions

As for the audit trail, I've created a simple view showing the comparison of the previous and current results together with the person editing and the day it was edited.

I'll work on the coordinators permissions .