Open constantinpape opened 3 years ago
Uh-huh... Thanks for a report, @constantinpape!
I'm able to reproduce the issue with both windows-2016
and windows-2019
environments so that's not it. The real reason seems to be related to the conda-incubator/setup-miniconda
step that your builds perform before setting up MSVC environment. That seems to conflict with something (maybe some shell defaults, or whatnot), making vcvarsall.bat
output something really unexpected that msvc-dev-cmd
cannot parse.
Reordering build steps seems to help. I've sent you a PR with a workaround. That should at least let you have a green build while I'm figuring our what exactly Python env breaks in MSVC scripts.
I'm able to reproduce the issue with both
windows-2016
andwindows-2019
environments so that's not it. The real reason seems to be related to theconda-incubator/setup-miniconda
step that your builds perform before setting up MSVC environment. That seems to conflict with something (maybe some shell defaults, or whatnot), makingvcvarsall.bat
output something really unexpected thatmsvc-dev-cmd
cannot parse.
Ok, good to know. I was just assuming that this was due to the latest windows build because this set up did work for me until a couple of weeks ago. But I guess some other change must have triggered the issue then.
Reordering build steps seems to help. I've sent you a PR with a workaround. That should at least let you have a green build while I'm figuring our what exactly Python env breaks in MSVC scripts.
Thanks!
I have been using the
mscv-dev-cmd
in a couple of my github workflowss to set the VC environment variables. This stopped working across the board a couple of weeks ago, without any changes to the workflow scripts. So I am assuming that this is related to an upgrade ofwindows-latest
in gh-workflows.This is one of the relevant recipes: https://github.com/constantinpape/z5/blob/master/.github/workflows/build.yml And here is a PR where the windows CI fails: https://github.com/constantinpape/z5/pull/181. See also the full error message below.
Any ideas on how to fix this would be highly welcome.