search

ilammy / msvc-dev-cmd

GitHub Action to setup Developer Command Prompt for Microsoft Visual C++
MIT License
338 stars 49 forks source link

chore: add buildtools edition #69

Closed qkdreyer closed 9 months ago

pzhlkj6612 commented 12 months ago

Hi! Your Git history looks not so good (This branch is 19 commits ahead, 1 commit behind ilammy:master). Maybe a git rebase a742a854f54111d83b78e97091b5d85ccdaa3e89 command can solve it.

qkdreyer commented 11 months ago

@pzhlkj6612 done!

pzhlkj6612 commented 11 months ago

Hi @qkdreyer , I have a question: how do you test your change? In GitHub's runner, this action is able to find the Enterprise edition of Visual Studio and will not try other editions. Are you using a self-hosted runner?

qkdreyer commented 11 months ago

yeah using a self hosted runner and installed using chocolatey : https://community.chocolatey.org/packages/visualstudio2019buildtools

qkdreyer commented 11 months ago

using https://github.com/qkdreyer/msvc-dev-cmd/releases/tag/v1-buildtools

image
qkdreyer commented 11 months ago

@ilammy

qkdreyer commented 9 months ago

can we merge that?

ilammy commented 9 months ago

Sorry for taking so long 🙇