ilap / slip39-js

The javascript implementation of the SLIP39 for Shamir's Secret-Sharing for Mnemonic Codes.
MIT License
69 stars 27 forks source link

Add failing test for 16 groups #12

Closed iancoleman closed 4 years ago

iancoleman commented 4 years ago

Using 16 groups of [1,1] with threshold 16 creates shares that cannot be recovered.

Error given is

Error: Invalid digest of the shared secret.

Also happens with threshold of 15 in 16 groups of [1,1]

Also happens with threshold of 15 in 15 groups of [1,1]

PR is just a failing test.

Tweaking the totalGroups and threshold in the test to any other combo will pass.

ilap commented 4 years ago

It's been fixed now and have added some unit tests.

iancoleman commented 4 years ago

Thanks! Do you know when 0.1.6 will become available on npm?

https://www.npmjs.com/package/slip39 is 0.1.5

ilap commented 4 years ago

Thanks! Do you know when 0.1.6 will become available on npm?

https://www.npmjs.com/package/slip39 is 0.1.5

Just published