Add Bootstrap classes to Markdown tables

ilastik / ilastik.github.io

https://ilastik.org

Other

3 stars 15 forks source link

Add Bootstrap classes to Markdown tables #152

Closed emilmelnikov closed 3 years ago

emilmelnikov commented 4 years ago

Markdown tables are generated without any classes, but Bootstrap requires adding .table classes in order for a table to be styled.

Closes https://github.com/ilastik/ilastik.github.io/issues/151

emilmelnikov commented 4 years ago

For some reason, a lot of lines in the changed documents had trailing whitespaces, so please ignore whitespace changes in the diff (git diff -w or check a checkbox in the GitHub diff UI).

emilmelnikov commented 4 years ago

is it possible to wrap those texts there (somehow enforce the table to the content width?)

Only if some text is out of the <pre> elements.

I've changed the text and formatting, but I'm not sure what the original documentation author meant (that is, where are identifiers_in_actual_data and where are their descriptions). @k-dominik could you make sure that the meaning is the same?

k-dominik commented 3 years ago

Hi @emilmelnikov , the table looks great! As for the Object IDs in that table: There are actually no identifiers in the data (I checked :o, e.g. here in case you want to make your eyes bleed). So this is more or less arbitrary. Maybe rename the Object IDs column in the table to Columns?

emilmelnikov commented 3 years ago

I also added a missing MultiFrameMoves dataset, and a note that we also have energy datasets.

k-dominik commented 3 years ago

that's cool. Could you check whether it is actually possible to generate these fields in export files? I have no clue how MultiFrameMoves are supposed to happen. (Quickly tried, but didn't manage to generate one).

Also about the energies: I would not know where these should come from in manual tracking...

emilmelnikov commented 3 years ago

Could you check whether it is actually possible to generate these fields in export files? I have no clue how MultiFrameMoves are supposed to happen.

I don't really understand very well what is going on in the manual tracking code, but it seems that multi-frame merges happen on this condition: https://github.com/ilastik/ilastik/blob/a7ee78d7936ed573b10c6ff4d8733e1f126a00ea/ilastik/applets/tracking/manual/manualTrackingGui.py#L938

Also about the energies: I would not know where these should come from in manual tracking...

Yes, I looked at the code, and in manual tracking we always write 0 energy for each event.