Closed m-novikov closed 4 years ago
this could potentially also address #57 :)
@emilmelnikov mentioned that using the old imagej1 api to query for OS should probably be avoided.
I would use it because:
There is no alternative in imagej2 API
There is no deprecation annotation
Personally I doubt that it will ever be deprecated
compelling argument :) @emilmelnikov what do you think?
I also found that alternatives seem to be somewhat convoluted. In the end we'd probably write and maintain our own routines for .isOSX()
et. al...
I looked up the implementation of IJ.isOSX()
and it just checks a system property. So we could just replace it with:
bool isMac = System.getProperty("os.name").toLowerCase().startsWith("mac");
I looked up the implementation of
IJ.isOSX()
and it just checks a system property. So we could just replace it with:bool isMac = System.getProperty("os.name").toLowerCase().startsWith("mac");
I mean why would we implement it ourselves if it's already implemented for us? :)
I mean why would we implement it ourselves if it's already implemented for us? :)
I don't have a strong opinion about this, but I wouldn't using ImageJ 1 for such a trivial thing.
At least it's going to be easy to replace if they every get rid of IJ
:)
Closes: #54