ilastik / ilastik4ij

ImageJ plugins to run ilastik workflows
MIT License
22 stars 17 forks source link

Make label for ilastik executable system specific #55

Closed m-novikov closed 4 years ago

m-novikov commented 4 years ago

Closes: #54

k-dominik commented 4 years ago

this could potentially also address #57 :)

m-novikov commented 4 years ago

@emilmelnikov mentioned that using the old imagej1 api to query for OS should probably be avoided.

I would use it because:

  1. There is no alternative in imagej2 API
  2. There is no deprecation annotation
  3. Personally I doubt that it will ever be deprecated
k-dominik commented 4 years ago
  • There is no alternative in imagej2 API

  • There is no deprecation annotation

  • Personally I doubt that it will ever be deprecated

compelling argument :) @emilmelnikov what do you think?

I also found that alternatives seem to be somewhat convoluted. In the end we'd probably write and maintain our own routines for .isOSX() et. al...

emilmelnikov commented 4 years ago

I looked up the implementation of IJ.isOSX() and it just checks a system property. So we could just replace it with:

bool isMac = System.getProperty("os.name").toLowerCase().startsWith("mac");
m-novikov commented 4 years ago

I looked up the implementation of IJ.isOSX() and it just checks a system property. So we could just replace it with:

bool isMac = System.getProperty("os.name").toLowerCase().startsWith("mac");

I mean why would we implement it ourselves if it's already implemented for us? :)

emilmelnikov commented 4 years ago

I mean why would we implement it ourselves if it's already implemented for us? :)

I don't have a strong opinion about this, but I wouldn't using ImageJ 1 for such a trivial thing.

k-dominik commented 4 years ago

At least it's going to be easy to replace if they every get rid of IJ :)