search

ilastik / ilastik4ij

ImageJ plugins to run ilastik workflows
MIT License
22 stars 17 forks source link

Be nice to OSX users and complete path to executable #62

Closed k-dominik closed 3 years ago

k-dominik commented 4 years ago

we should not require users to navigate inside the .app, since we know were to find the ilastik executable from there.

There is one thing I don't like about this solution with the callback: It immediately modifies the path, which is not intuitive to a user (imo).

so I abandoned the callback and implemented a getter for the executable file path in the AbstractExecutor class. I just don't want to bother users with the internals of our .app at all.

fixes #57

Todos:

k-dominik commented 4 years ago

ok bummer. I tested it on OSX and of course there is a problem. The Parameter is of type File, depending on the style. For OSX we'd actually want to select a folder. @m-novikov, in your search for a OS-dependent label, did you stumble upon anything we could exploit there? style can be passed to the parameter to achieve a file, vs a directory chooser.

I guess I can follow your pattern from #55 directly.

k-dominik commented 4 years ago

okay, it's really working on osx now, finally. Could you have another look @emilmelnikov ?