ilastik / ilastik4ij

ImageJ plugins to run ilastik workflows
MIT License
22 stars 17 forks source link

Read object features table #84

Closed emilmelnikov closed 1 year ago

emilmelnikov commented 3 years ago

Add the ability to read an object features table from object classification workflow.

Also, refactor and simplify all workflows and associated demos.

Closes https://github.com/ilastik/ilastik4ij/issues/56.

k-dominik commented 3 years ago

Are these changes backwards compatible (e.g. will old macros still run)? I've tried some of my old ones, but so far without success.

for Pixel Classification it seems that parameters have been renamed:

I know this sucks, I like the more expressive parameter names, too, but we can't break old macros because of an internal refactor

emilmelnikov commented 3 years ago

Are these changes backwards compatible (e.g. will old macros still run)? I've tried some of my old ones, but so far without success.

for Pixel Classification it seems that parameters have been renamed:

  • projectfilename -> project
  • inputimage -> rawdata

I know this sucks, I like the more expressive parameter names, too, but we can't break old macros because of an internal refactor

Good call, I forgot about macros.

k-dominik commented 3 years ago

Just to add now that I looked at the code it is really nice to see reduced amount of duplication and boilerplate for the workflows! I tested generating the tables and this works nicely as well. We'll have to add documentation for this though, as one has to configure the csv export in ilastik first - otherwise it won't work. The real power of the table can be unleashed once we allow for exporting the Object Identities. That way (I think) one could use feature table as colormaps (somehow) :D. We should maybe ask @tischi how to best do it and provide an example.

emilmelnikov commented 3 years ago

We'll have to add documentation for this though, as one has to configure the csv export in ilastik first - otherwise it won't work.

Would this work?

image

emilmelnikov commented 3 years ago

The real power of the table can be unleashed once we allow for exporting the Object Identities.

I presume we need to change table export in ilastik for this?

k-dominik commented 3 years ago

The real power of the table can be unleashed once we allow for exporting the Object Identities.

I presume we need to change table export in ilastik for this?

no, we'd need to allow exporting a different source via --export_source=Object Identities" command line argument.

We'll have to add documentation for this though, as one has to configure the csv export in ilastik first - otherwise it won't work.

Would this work?

image

that's perfect :) users don't even need to look into some docs.

emilmelnikov commented 3 years ago

we'd need to allow exporting a different source via --export_source=Object Identities" command line argument.

Should we address this in a separate PR?

emilmelnikov commented 1 year ago

Superseded by https://github.com/ilastik/ilastik4ij/pull/106.

Object features table could be addressed in a separate PR.