ilastik / lazyflow

lazy parallel ondemand zero copy numpy array data flows with caching and dirty propagation
Other
77 stars 59 forks source link

Error using pixel classification with 2D h5 files #271

Closed hfahad closed 5 years ago

hfahad commented 6 years ago

issue #1749 solved that open in ilastik but i found the bug in lazyflow

during 2d Data in pixelClassificationDataExportGui.py file show error that 'c' is not found that why i put a condition if 'c' is not found then add a channel during hdf5 reader and also 'c' in axistags and in the end execute function we already change the dimension and axis info of the data. but when we read again data from orignal hdf5 file i face some error thats why i comeback to original shape to execute the data

k-dominik commented 6 years ago

hmm, yes, could you please rebase this branch onto master and force push it again?

# on lazyflow master branch
# assuming upstream is configured to be ilastik/lazyflow
git fetch upstream master
git rebase upstream/master

# then switch to your feature branch, rebase it onto the current master and force push the result
git checkout pixel-clasification-2d-image-error
git rebase master
git push --force

just in order to include recent fixes, thanks!

hfahad commented 6 years ago

done it .

k-dominik commented 6 years ago

There seem to be some legitimate test failures in testOpFormattedDataExport.TestOpFormattedDataExport.testBasic and . have you run the tests yourself?

you can do that by

# assuming you are in ilastik-meta/lazyflow
nosetests --where=./tests

you should see then, that two of the tests fail.

I think this has something to do with the additional channel, that is added to data without a channel.

Please also note that due some recent changes you have to update the fastfilters package in your conda environment:

# assuming you have activated the environment
conda update -c ilastik-forge fastfilters 
k-dominik commented 6 years ago

fixes https://github.com/ilastik/ilastik/issues/1845, https://github.com/ilastik/ilastik/issues/1749

k-dominik commented 6 years ago

on hold for now, as this breaks some things in ilastik, mostly tests