ilastik / volumina

Volume Slicing and Editing
http://ilastik.org
Other
32 stars 65 forks source link

Fix Scrolling: Alt + mouse wheel #294

Closed jonashund closed 2 years ago

jonashund commented 2 years ago

Fix issue ilastik/ilastik#2009

Qt.AltModifier inverts vertical and horizontal scrolling directions as an intended behaviour

The change in indentation in line 36 was caused by hook id: black while committing. Thus, I refrained from reverting it this time, but appreciate tips how to avoid such changes in the first place in the future.

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Base: 35.74% // Head: 35.77% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (68e6b56) compared to base (3ec9102). Patch coverage: 25.00% of modified lines in pull request are covered.

:exclamation: Current head 68e6b56 differs from pull request most recent head cc92cbd. Consider uploading reports for the commit cc92cbd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #294 +/- ## ========================================== + Coverage 35.74% 35.77% +0.02% ========================================== Files 106 106 Lines 11291 11290 -1 ========================================== + Hits 4036 4039 +3 + Misses 7255 7251 -4 ``` | [Impacted Files](https://codecov.io/gh/ilastik/volumina/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ilastik) | Coverage Δ | | |---|---|---| | [volumina/navigationController.py](https://codecov.io/gh/ilastik/volumina/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ilastik#diff-dm9sdW1pbmEvbmF2aWdhdGlvbkNvbnRyb2xsZXIucHk=) | `17.79% <25.00%> (+0.15%)` | :arrow_up: | | [volumina/widgets/dataExportOptionsDlg.py](https://codecov.io/gh/ilastik/volumina/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ilastik#diff-dm9sdW1pbmEvd2lkZ2V0cy9kYXRhRXhwb3J0T3B0aW9uc0RsZy5weQ==) | `18.75% <0.00%> (+0.27%)` | :arrow_up: | | [volumina/\_\_init\_\_.py](https://codecov.io/gh/ilastik/volumina/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ilastik#diff-dm9sdW1pbmEvX19pbml0X18ucHk=) | `91.30% <0.00%> (+8.69%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ilastik). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ilastik)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

k-dominik commented 2 years ago

as a bonus (for us) you could pin the qt version in the conda recipe to a max of 5.12.*, so that the tests will pass :) (qt got a recently updated on conda-forge - haven't looked into why it's breaking volumina yet).

https://github.com/ilastik/volumina/blob/06b4b19eccb95ff54af13bc346587bbe2f2d2cd2/conda-recipe/meta.yaml#L23

jonashund commented 2 years ago

Hi @k-dominik,

jonashund commented 2 years ago

@k-dominik If you could test the fix on macOS again, the commonly used platforms should be covered.

k-dominik commented 2 years ago

thank you @jonashund for your contribution 🙌 :)