search

ilastik / volumina

Volume Slicing and Editing
http://ilastik.org
Other
32 stars 65 forks source link

Add export option for single-scale OME-Zarr #316

Closed btbest closed 3 days ago

btbest commented 1 month ago

Instead of adding a triplicate of the H5/N5 file options widget, I figured I'd combine them instead. Still pondering whether the one point of custom logic for zarr (allowing dataset to be empty) warrants a duplicate, but don't really think so. Not sure why it's mandatory anyway; there is ilastik code that enforces an internal path to be present for H5 but not N5.

I've put the menu option under the below hierarchical formats for now, but that's easy to relocate if we want to have it further up or down the list.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 36.48%. Comparing base (baf0c13) to head (5292923). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ina/widgets/hierarchicalFileExportOptionsWidget.py 0.00% 18 Missing :warning:
.../widgets/multiformatSlotExportFileOptionsWidget.py 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #316 +/- ## ========================================== - Coverage 36.58% 36.48% -0.10% ========================================== Files 108 107 -1 Lines 11489 11371 -118 ========================================== - Hits 4203 4149 -54 + Misses 7286 7222 -64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

btbest commented 1 week ago

Ready to merge when ilastik PR is done