search

ilbers / isar

Integration System for Automated Root filesystem generation
Other
177 stars 72 forks source link

isar-setup-builddir only looks for .sample files in TEMPLATECONF folder #55

Open protenhan opened 5 years ago

protenhan commented 5 years ago

I'm quite new to using isar and bitbake but so far I found working with it a quite smooth experience. However, I observed that the isar-setup-builddir script is only copying the content of bblayers.conf.sample and local.conf.sample to build/conf/. See here https://github.com/ilbers/isar/blob/596732aa99c361b756655434bc90e0108e1caa33/scripts/isar-setup-builddir#L69-L70

This will display an error message that the directory configured in .templateconf does not contain a local.conf file and also no bblayers.conf. My naive assumption would be that I could provide a meta-isar/conf/local.conf right next to the meta-isar/conf/local.conf.sample and isar-setup-builddir would take this one instead and also not show the warning message.

Something like this:

if [ -r "$TEMPLATECONF/bblayers.conf"]; then
    ISARCORELAYERCONF="$TEMPLATECONF/bblayers.conf"
else
    ISARCORELAYERCONF="$TEMPLATECONF/bblayers.conf.sample"
fi

Or is this a design decision because of how Bitbake works? I myself like the approach of just deleting the whole build folder and then let isar take care of copying the files to the right locations.