Fixed bug when uploading file more than 20mb

elephantchau commented 2 years ago

API call for telegram.getFile(fileId) will fail when uploading file more than 20mb. Replaced with simple split function to get file extension

elephantchau commented 2 years ago

Code tested with document type file uploads. Original code will fail when file size is more than 20mb.

ilbertt commented 2 years ago

@elephantchau thanks for the PR and sorry for the late reply! Your fix makes totally sense, I've added a comment to change variable declaration from let to const just for best practices purposes. If you could fix it, I'll be really happy to merge your PR! And, if you'd like to reply, I have some questions just for curiosity:

how did you find out about infinitecloud_bot?
did you try also the dashboard?
are you self-hosting it?
what are your general experience feedbacks about the bot?

elephantchau commented 2 years ago

@Luca8991 Thanks for the code review! I'm glad I'm able to have some contribution on your project!

I had an idea of making a telegram infinite cloud storage thing by myself for infinite storage purposes like you did, and came across your repo for some working examples. I tested some of the functions and found some easy fixes so I did.
I did not try the dashboard, maybe some time later.
I was not going to self-host and I ended up building a telegram client for myself (not bot). I can directly interact with my client for uploads and downloads and never have the need to open telegram app / website again. Single file size limits at 2GB too. The transferring speed was fair, not the fastest I've seen.
I thought the bot was a really cool concept and lightweight to use. It should take minimal processing power to get it going.

ilbertt / infinitecloud_bot

Fixed bug when uploading file more than 20mb #3